Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pydantic v2 #91

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

sharonyogev
Copy link
Contributor

This add support for pydantic v2 without dropping support to pydantic v1
I would love this to be merged soon so I can upgrade pydantic in my project

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.38% 🎉

Comparison is base (e7968b4) 90.73% compared to head (3a38fe1) 91.12%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   90.73%   91.12%   +0.38%     
==========================================
  Files           2        2              
  Lines         205      214       +9     
==========================================
+ Hits          186      195       +9     
  Misses         19       19              
Files Changed Coverage Δ
src/pydantic_avro/base.py 98.19% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanRademaker
Copy link
Collaborator

DaanRademaker commented Aug 3, 2023

Looking pretty good to me. Will ask some feedback from other maintainers as well.
For now, the isort check is failing so that needs to be fixed.

@sharonyogev
Copy link
Contributor Author

Thanks, updated the isort problem 🙏
BTW, note that since I added the pydantic-version to the version matrix, it failed to find the required check

Copy link
Contributor

@timvancann timvancann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice addition.

@timvancann timvancann merged commit de0b87d into godatadriven:main Aug 3, 2023
15 checks passed
@sharonyogev
Copy link
Contributor Author

Great, thank you very much for the really quick response 🙏🙏🙏
Do you guys knows when are you planning on release a new version of the package?

@timvancann
Copy link
Contributor

@sharonyogev Just made a new release for you.
https://pypi.org/project/pydantic-avro/

@sharonyogev
Copy link
Contributor Author

@timvancann I think you force push some commits that removed this merged PR...
Can you check, if you want me to rebase and re-open the PR tell me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants