+

godot-codegen/src/generator/default_parameters.rs

@@ -398,8 +398,8 @@ fn make_field_init(
     match (conversion, expr) {
         (Conv::ObjectArg, Some(expr)) => quote! { #name: #expr.consume_object() },
         (Conv::ObjectArg, None) /*.             */ => quote! { #name: #name.consume_object() },
-        (Conv::Reference, Some(expr)) => quote! { #name: & #expr },
-        (Conv::Reference, None) /*.             */ => quote! { #name: & #name },
+        (Conv::Reference, Some(expr)) => quote! { #name: #expr },
+        (Conv::Reference, None) /*.             */ => quote! { #name },
         (Conv::None | Conv::ReferenceWithDefault, Some(expr)) => quote! { #name: #expr },
         (Conv::None | Conv::ReferenceWithDefault, None) /*.             */ => quote! { #name },
     }

godot-core/src/lib.rs

@@ -48,6 +48,7 @@ compile_error!("Generating editor docs for Rust symbols requires at least Godot
 #[allow(clippy::let_unit_value)] // let args = ();
 #[allow(clippy::wrong_self_convention)] // to_string() is const
 #[allow(clippy::upper_case_acronyms)] // TODO remove this line once we transform names
+#[allow(clippy::needless_lifetimes)]  // the following explicit lifetimes could be elided: 'a
 #[allow(unreachable_code, clippy::unimplemented)] // TODO remove once #153 is implemented
 mod gen {
     include!(concat!(env!("OUT_DIR"), "/mod.rs"));

godot-core/src/meta/godot_convert/mod.rs

@@ -95,18 +95,12 @@ pub trait FromGodot: Sized + GodotConvert {
     }
 }
 
-// pub(crate) fn into_ffi<'v, T: ToGodot >(value: T) -> <T::ToVia<'v> as GodotType>::Ffi {
-//     let by_ref = value.to_godot();
-//     let ffi = by_ref.to_ffi();
-//
-//     ffi
-// }
-
+// Note: removing the implicit lifetime (by taking value: T instead of &T) causes issues due to allegedly returning a lifetime
+// to a local variable, even though the result Ffi is 'static by definition.
+#[allow(clippy::needless_lifetimes)] // eliding causes error: missing generics for associated type `godot_convert::ToGodot::ToVia`
 pub(crate) fn into_ffi<'v, T: ToGodot>(value: &'v T) -> <T::ToVia<'v> as GodotType>::Ffi {
     let by_ref = value.to_godot();
-    let ffi = by_ref.to_ffi();
-
-    ffi
+    by_ref.to_ffi()
 }
 
 pub(crate) fn into_ffi_variant<T: ToGodot>(value: &T) -> Variant {

itest/rust/src/builtin_tests/containers/array_test.rs

@@ -53,7 +53,7 @@ fn array_from_packed_array() {
     // This tests that the resulting array doesn't secretly have a runtime type assigned to it,
     // which is not reflected in our static type. It would make sense if it did, but Godot decided
     // otherwise: we get an untyped array.
-    array.push(&GString::from("hi").to_variant());
+    array.push(GString::from("hi").to_variant());
     assert_eq!(array, varray![42, "hi"]);
 }