Deprecate instance utilities in godot::global
#901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-901 |
Bromeon
force-pushed
the
qol/deprecate-instance-utilities
branch
from
bc802b8
to
8b37feb
Compare
Bromeon
force-pushed
the
qol/deprecate-instance-utilities
branch
from
8979e84
to
ece7360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
godot::globalutilitiesinstance_from_id(),is_instance_valid(), andis_instance_id_valid().Their removal is planned in v0.3.
This functionality is fully covered by:
Gd::instance_id()Gd::from_instance_id()InstanceId::lookup_validity()-- added in this PRThe functions in
godot::globalare redundant and introduce more backdoors for object interaction, bypassing invariants or runtime checks. The functions are very easy to overlook in a design, e.g. in #886.CI blocked by #899.