Replace generic macros with math equivalents #1503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
added
the
enhancement
Repiteo
force-pushed
the
math-replace-macros
branch
from
2ec7434 to
67e004e
Compare
AThousandShips
added
waiting for Godot
Repiteo
force-pushed
the
math-replace-macros
branch
from
67e004e to
5b72955
Compare
Repiteo
force-pushed
the
math-replace-macros
branch
from
5b72955 to
48ec701
Compare
|
Thanks! This looks good at a first glance :-)
I'd still prefer to wait until the Godot PR is merged, so that we can be sure this PR is sync'd with the latest version of the code there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
godot-cpp counterpart to godotengine/godot#91324
As this is already largely implemented on godot-cpp's side already, this isn't technically dependant on the aforementioned PR (though it does lift the internals &
constexpr). Rather, this focuses on converting whatever remaining macro instances existed with their math equivalents, and labeling the macros as deprecated.