Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for virtual method compatibility system #1676

Merged

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Dec 21, 2024

This implements the virtual method compatibility system from PR godotengine/godot#100674

Marking as DRAFT until that PR is merged

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Dec 21, 2024
@dsnopek dsnopek added this to the 4.x milestone Dec 21, 2024
@dsnopek dsnopek requested a review from a team as a code owner December 21, 2024 00:00
@dsnopek dsnopek marked this pull request as draft December 21, 2024 00:00
@dsnopek dsnopek force-pushed the gdextension-virtual-method-compat branch from 573c608 to 5c9529f Compare January 11, 2025 22:37
@dsnopek dsnopek changed the title [DRAFT] Update for virtual method compatibility system Update for virtual method compatibility system Jan 11, 2025
@dsnopek dsnopek marked this pull request as ready for review January 11, 2025 22:37
@dsnopek
Copy link
Collaborator Author

dsnopek commented Jan 11, 2025

Now that PR godotengine/godot#100674 is merged, taking this one out of draft!

Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look straightforward 👍🏻 haven't tested it though.

@dsnopek dsnopek merged commit 65046d0 into godotengine:master Jan 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants