Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of GDExtension written pure C #10403

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Dec 12, 2024

This salvages @vnen's PR #8751

I applied almost all the suggestions there (I disagreed with a small handful of them :-)).

I think vnen had a repo with the full project somewhere which I need to dig up, so I can update it for the few code changes here and test that everything actually works as written.

@dsnopek dsnopek added this to the 4.x milestone Dec 12, 2024
@dsnopek dsnopek added enhancement content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Dec 12, 2024
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for grammar, style, and formatting. Generally looks good, overall very clear. I made a bunch of style nitpick suggestions.

tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdextension/gdextension_c_example.rst Outdated Show resolved Hide resolved
@tetrapod00 tetrapod00 removed this from the 4.x milestone Dec 12, 2024
@tetrapod00
Copy link
Contributor

tetrapod00 commented Dec 12, 2024

FYI in the docs repo we currently only use milestones for PRs that only apply to the latest minor version, in this case 4.4. Everything else gets no milestone

(Maybe we should use them more. But we don't 🤷 )

@dsnopek dsnopek force-pushed the redo-vnen-8751 branch 3 times, most recently from fecf654 to e373059 Compare December 13, 2024 16:47
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, read it twice for proofreading, and approving the concept of this tutorial. I didn't have time to actually test any of it, but I'll trust vnen and dsnopek on the technical accuracy :)

@dsnopek dsnopek marked this pull request as draft December 15, 2024 15:31
@dsnopek dsnopek marked this pull request as ready for review December 15, 2024 15:49
@dsnopek
Copy link
Contributor Author

dsnopek commented Dec 15, 2024

Per my original note in the description:

I think vnen had a repo with the full project somewhere which I need to dig up, so I can update it for the few code changes here and test that everything actually works as written.

I've cloned vnen's repo and tested all the code updates that were made to the tutorial - you can find my updated version here:

https://github.com/dsnopek/gdextension-c-example/tree/drs

So, the current code in the tutorial is all tested as working now :-)

We should probably move the complete code to somewhere official, although, I'm not exactly sure where?

@mhilbrunner
Copy link
Member

We should probably move the complete code to somewhere official, although, I'm not exactly sure where?

We have (had) https://github.com/godotengine/gdnative-demos once upon a time. It may make sense to createa gdextension-demos repo. Should probably be discussed with Akien.

@mhilbrunner mhilbrunner merged commit 273f9a7 into godotengine:master Dec 15, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you! Also pinged Akien about the repo in #gdextension on RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features enhancement topic:gdextension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants