Fix AudioStreamWAV::save_to_wav adding extra '.wav' to file if existing ext is not lower case
#98717
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Nov 1, 2024
mhilbrunner
approved these changes
Nov 1, 2024
fire
changed the title
AudioStreamWAV::save_to_wav adding extra '.wav' to file if existing ext is not lower caseAudioStreamWAV::save_to_wav adding extra '.wav' to file if existing ext is not lower case
AThousandShips
approved these changes
Nov 1, 2024
nikitalita
force-pushed
the
fix-save-to-wav-caps
branch
from
1407fdb
to
08db8ed
Compare
AThousandShips
added
cherrypick:4.2
ShadowNotDefined
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98719
Pretty simple: if the file_path passed in contains an upper-case extension (e.g. ".WAV"), it would add an extra ".wav" on top of that. A simple
.to_lower()fixes this.