Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations are not updated when dynamically loading PCK #98728

Open
mihe opened this issue Nov 1, 2024 · 0 comments
Open

Translations are not updated when dynamically loading PCK #98728

mihe opened this issue Nov 1, 2024 · 0 comments

Comments

@mihe
Copy link
Contributor

mihe commented Nov 1, 2024

Tested versions

Reproducible in 4.4.dev [ef8d981]

System information

Windows 11 (10.0.22631)

Issue description

When including updated translation files as part of an exported PCK file that's meant to be dynamically loaded at runtime, you currently have to manually load each *.translation file after having loaded the PCK in order for the updated translations to actually have any effect.

The expected behavior would be for the updated translations to be loaded as part of loading the PCK.

Steps to reproduce

(The MRP includes a patch.pck file that was exported using the patch system introduced in #97118, where the translation with key HELLO was changed from "Hello" to "Howdy" before exporting.)

  1. Open the MRP.
  2. Run the main scene.
  3. Note how the label says "Hello".
  4. Uncomment the ResourceLoader.load line in main.gd.
  5. Run the main scene again.
  6. Note how the label now says "Howdy".

Minimal reproduction project (MRP)

localization-patching.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant