Make strict typing for scalar arguments opt-in

goetas-webservices · Dec 16, 2022 · e491194 · e491194
1 parent c83895a
commit e491194
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/src/Php/ClassGenerator.php b/src/Php/ClassGenerator.php
@@ -17,6 +17,13 @@
 
 class ClassGenerator
 {
+    private $strictTypes;
+
+    public function __construct(bool $strictTypes = false)
+    {
+        $this->strictTypes = $strictTypes;
+    }
+
     private function handleBody(Generator\ClassGenerator $class, PHPClass $type)
     {
         foreach ($type->getProperties() as $prop) {
@@ -144,23 +151,26 @@ private function handleSetter(Generator\ClassGenerator $generator, PHPProperty $
         } elseif ($type) {
             if ($type->isNativeType()) {
                 $patramTag->setTypes($type->getPhpType());
-                $parameter->setType($type->getPhpType()); // Added by rvdb: add strict typing for scalar arguments
+                if ($this->strictTypes) {
+                    $parameter->setType($type->getPhpType());
+                }
             } elseif ($p = $type->isSimpleType()) {
                 if (($t = $p->getType()) && !$t->isNativeType()) {
                     $patramTag->setTypes($t->getPhpType());
                     $parameter->setType($t->getPhpType());
                 } elseif ($t) {
                     $patramTag->setTypes($t->getPhpType());
-                    $parameter->setType($t->getPhpType()); // Added by rvdb: add strict typing for simple arguments
-
+                    if ($this->strictTypes) {
+                        $parameter->setType($t->getPhpType());
+                    }
                 }
             } else {
                 $patramTag->setTypes($type->getPhpType());
                 $parameter->setType(($prop->getNullable() ? '?' : '') . $type->getPhpType());
             }
         }
 
-        if ($prop->getDefault() === null) {      // Added by rvdb: make setter arguments nullable
+        if ($this->strictTypes && $prop->getDefault() === null) {
             $parameter->setDefaultValue(null);
         }
 

diff --git a/tests/AbstractGenerator.php b/tests/AbstractGenerator.php
@@ -19,6 +19,7 @@ abstract class AbstractGenerator
 {
     protected $targetNs = [];
     protected $aliases = [];
+    protected $strictTypes;
 
     protected $phpDir;
     protected $jmsDir;
@@ -28,12 +29,14 @@ abstract class AbstractGenerator
 
     private $loader;
 
-    public function __construct(array $targetNs, array $aliases = [], $tmp = null)
+
+    public function __construct(array $targetNs, array $aliases = [], $tmp = null, bool $strictTypes = false)
     {
         $tmp = $tmp ?: sys_get_temp_dir();
 
         $this->targetNs = $targetNs;
         $this->aliases = $aliases;
+        $this->strictTypes = $strictTypes;
 
         $this->phpDir = "$tmp/php";
         $this->jmsDir = "$tmp/jms";
@@ -146,7 +149,7 @@ protected function writePHP(array $items)
         $pathGenerator = new PhpPsr4PathGenerator($paths);
 
         $classWriter = new PHPClassWriter($pathGenerator);
-        $writer = new PHPWriter($classWriter, new ClassGenerator());
+        $writer = new PHPWriter($classWriter, new ClassGenerator($this->strictTypes));
         $writer->write($items);
     }