Fix resources-stringslice parsing after urfavecli to v2 upgrade (#402)

gogatekeeper · Dec 8, 2023 · 46c342c · 46c342c
1 parent fcd0e84
commit 46c342c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/e2e/e2e_test.go b/e2e/e2e_test.go
@@ -117,6 +117,7 @@ var _ = Describe("NoRedirects Simple login/logout", func() {
 			"--client-secret=" + testClientSecret,
 			"--upstream-url=" + server.URL,
 			"--no-redirects=true",
+			"--enable-default-deny=false",
 			"--skip-access-token-clientid-check=true",
 			"--skip-access-token-issuer-check=true",
 			"--openid-provider-retry-count=30",
@@ -177,6 +178,8 @@ var _ = Describe("Code Flow login/logout", func() {
 			"--skip-access-token-clientid-check=true",
 			"--skip-access-token-issuer-check=true",
 			"--enable-idp-session-check=false",
+			"--enable-default-deny=false",
+			"--resources=uri=/*|roles=uma_authorization,user",
 			"--openid-provider-retry-count=30",
 			"--enable-refresh-tokens=true",
 			"--encryption-key=sdkljfalisujeoir",

diff --git a/pkg/proxy/cli.go b/pkg/proxy/cli.go
@@ -36,6 +36,8 @@ import (
 func NewOauthProxyApp() *cli.App {
 	cfg := config.ProduceConfig(proxycore.Provider)
 	app := cli.NewApp()
+	// we had to set this after upgrade from urvafe v1 to v2
+	app.DisableSliceFlagSeparator = true
 	app.Name = constant.Prog
 	app.Usage = constant.Description
 	app.Version = proxycore.GetVersion()