Support for merging messages implementing Merger which are embedded by value #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue with Clone to enable support for proto.Merger for types that are embedded as values.
Example of such scenario is overriding the type of the generated protobuf attribite to use a type from the Go's standard library - e.g. time.Time:
which results in the following type:
Values of such type cannot be
Clone
d as time.Time has unexported fields.Additionally, if MyResource implements
proto.Merger
it is not used.I'm not entirely sure this is the correct repository for this change as iiuc the proto/ code is partially based on another repository which, in turn, is using yet another one. I'd appreciate it if you let me know whether this change is better addressed in one of these repositories instead.