Hardcode the overlay result to be a PNG instead of following the orig…

…inal base image format
gojek · Jan 19, 2020 · f7ad58d · f7ad58d
1 parent 324fc22
commit f7ad58d
Show file tree

Hide file tree

Showing 12 changed files with 11 additions and 11 deletions.
diff --git a/...or/native/_testdata/overlay/overlay_1.jpg → ...or/native/_testdata/overlay/overlay_1.png b/...or/native/_testdata/overlay/overlay_1.jpg → ...or/native/_testdata/overlay/overlay_1.png
diff --git a/...r/native/_testdata/overlay/overlay_19.jpg → ...r/native/_testdata/overlay/overlay_19.png b/...r/native/_testdata/overlay/overlay_19.jpg → ...r/native/_testdata/overlay/overlay_19.png
diff --git a/...or/native/_testdata/overlay/overlay_2.jpg → ...or/native/_testdata/overlay/overlay_2.png b/...or/native/_testdata/overlay/overlay_2.jpg → ...or/native/_testdata/overlay/overlay_2.png
diff --git a/...or/native/_testdata/overlay/overlay_3.jpg → ...or/native/_testdata/overlay/overlay_3.png b/...or/native/_testdata/overlay/overlay_3.jpg → ...or/native/_testdata/overlay/overlay_3.png
diff --git a/...or/native/_testdata/overlay/overlay_4.jpg → ...or/native/_testdata/overlay/overlay_4.png b/...or/native/_testdata/overlay/overlay_4.jpg → ...or/native/_testdata/overlay/overlay_4.png
diff --git a/...or/native/_testdata/overlay/overlay_5.jpg → ...or/native/_testdata/overlay/overlay_5.png b/...or/native/_testdata/overlay/overlay_5.jpg → ...or/native/_testdata/overlay/overlay_5.png
diff --git a/...or/native/_testdata/overlay/overlay_6.jpg → ...or/native/_testdata/overlay/overlay_6.png b/...or/native/_testdata/overlay/overlay_6.jpg → ...or/native/_testdata/overlay/overlay_6.png
diff --git a/...or/native/_testdata/overlay/overlay_7.jpg → ...or/native/_testdata/overlay/overlay_7.png b/...or/native/_testdata/overlay/overlay_7.jpg → ...or/native/_testdata/overlay/overlay_7.png
diff --git a/...or/native/_testdata/overlay/overlay_8.jpg → ...or/native/_testdata/overlay/overlay_8.png b/...or/native/_testdata/overlay/overlay_8.jpg → ...or/native/_testdata/overlay/overlay_8.png
diff --git a/...or/native/_testdata/overlay/overlay_9.jpg → ...or/native/_testdata/overlay/overlay_9.png b/...or/native/_testdata/overlay/overlay_9.jpg → ...or/native/_testdata/overlay/overlay_9.png
diff --git a/pkg/processor/native/processor.go b/pkg/processor/native/processor.go
@@ -236,7 +236,7 @@ func (bp *BildProcessor) Overlay(base []byte, overlays []*processor.OverlayAttrs
 		}
 	}
 
-	return bp.Encode(baseImg, f)
+	return bp.Encode(baseImg, processor.ExtensionPNG)
 }
 
 // WithEncoders is a builder function to set custom Encoders for BildProcessor

diff --git a/pkg/processor/native/processor_test.go b/pkg/processor/native/processor_test.go
@@ -293,7 +293,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			overlays: []*processor.OverlayAttrs{},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_1.jpg",
+			expected: "./_testdata/overlay/overlay_1.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -304,7 +304,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_2.jpg",
+			expected: "./_testdata/overlay/overlay_2.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -315,7 +315,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_3.jpg",
+			expected: "./_testdata/overlay/overlay_3.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -326,7 +326,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_4.jpg",
+			expected: "./_testdata/overlay/overlay_4.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -337,7 +337,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_5.jpg",
+			expected: "./_testdata/overlay/overlay_5.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -348,7 +348,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_6.jpg",
+			expected: "./_testdata/overlay/overlay_6.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -359,7 +359,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_7.jpg",
+			expected: "./_testdata/overlay/overlay_7.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -370,7 +370,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_8.jpg",
+			expected: "./_testdata/overlay/overlay_8.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -381,7 +381,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_9.jpg",
+			expected: "./_testdata/overlay/overlay_9.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,
@@ -392,7 +392,7 @@ func (s *BildProcessorSuite) TestBildProcessor_Overlay() {
 			},
 		},
 		{
-			expected: "./_testdata/overlay/overlay_19.jpg",
+			expected: "./_testdata/overlay/overlay_19.png",
 			overlays: []*processor.OverlayAttrs{
 				{
 					Img:              overlay,