Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional net/http/pprof server support (off by default) #5

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 4, 2023

For profiling over the network, without using --cpuprofile to persistent storage. Useful if you don't have persistent storage (or don't want to deal with it). Also debug/pprof does more.

At first I was concerned about doing this for binary bloat reasons, but this basically adds nothing new. The transitive deps already included net/http, runtime/pprof, etc.

For profiling over the network, without using --cpuprofile to
persistent storage. Useful if you don't have persistent storage (or
don't want to deal with it). Also debug/pprof does more.

At first I was concerned about doing this for binary bloat reasons,
but this basically adds nothing new. The transitive deps already
included net/http, runtime/pprof, etc.
@bradfitz
Copy link
Contributor Author

bradfitz commented Apr 4, 2023

cc @stapelberg

@stapelberg stapelberg merged commit e06e129 into gokrazy:main Apr 4, 2023
@stapelberg
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants