Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support openssl v2 module #131

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

derekparker
Copy link
Contributor

No description provided.

@derekparker
Copy link
Contributor Author

There's still some cleanup with regard to the patch files, especially the fixup ones, however I know we've discussed applying the patches directly to the tree anyways, so I'm open to that discussion and essentially squashing and applying all the patches directly to the tree.

Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundled patches look good to me.

@@ -1,5 +1,5 @@
{
"github.com/golang-fips/go": "main",
"github.com/golang-fips/openssl-fips": "b175be2ccd46683a51cba60a9a2087b09593317d",
"github.com/golang-fips/openssl-fips": "7544e9a0711b109a2c114b021d079263a3d683a1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you probably noticed already, the key should be changed to "github.com/golang-fips/openssl" as the other script expects.

@derekparker
Copy link
Contributor Author

@ueno after updating the config it appears there are still failures on centos stream 9 and ubi9.

@ueno
Copy link
Collaborator

ueno commented Oct 16, 2023

In crypto/rsa:

--- FAIL: TestSignPKCS1v15 (0.00s)
--- FAIL: TestVerifyPKCS1v15 (0.00s)

should be fixed with ueno/go@6640803.

--- FAIL: TestKeyGeneration (1.28s)
--- FAIL: TestDecryptOAEP (0.00s)

openssl/v2 module needs to be updated to include golang-fips/openssl#119

In crypto/x509:

--- FAIL: TestGoVerify (0.01s)

I guess we could only remove the problematic certificates; I can look into it further if needed.

--- FAIL: TestImports (0.93s)
--- FAIL: TestDisableSHA1ForCertOnly (0.00s)

should be fixed with ueno/go@662ae4c

Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekparker derekparker merged commit 56ac3db into golang-fips:main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants