Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gomobile: add a flag to manually specify a work dir #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aeddi
Copy link

@aeddi aeddi commented Nov 26, 2020

Added a flag to manually specify a work dir to avoid having to rebuild everything from scratch when using gomobile through go module.

Particularly useful in the context of a large project that takes several tens of minutes to build, especially when only one or two packages need to be recompiled.

Fixes golang/go#37902

@google-cla google-cla bot added the cla: yes label Nov 26, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: cf45366) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/273406 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: bfaf3f5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/273406 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hajime Hoshi:

Patch Set 2: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=bd7c9bf3


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Antoine Eddi:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Antoine Eddi:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e7699dc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/273406 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Antoine Eddi:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Antoine Eddi:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 2ebcbb6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/273406 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Antoine Eddi:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/273406.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b169a72) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/273406 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: bee19d4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/273406 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/mobile: binding doens't seem to reuse build cache for modules
2 participants