-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: use cgo.Handle for service object #158
base: master
Are you sure you want to change the base?
Conversation
This fixes go vet complaints and checkptr crashes when the handler receives an event, e.g. a session change notification. Fixes golang/go#59687
c53a2e5
to
fe43297
Compare
This PR (HEAD: fe43297) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/490135 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Quim Muntal: Patch Set 1: Run-TryBot+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Gopher Robot: Patch Set 1: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Gopher Robot: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Quim Muntal: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Gopher Robot: Patch Set 1: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
Message from Bryan Mills: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. |
This fixes go vet complaints and checkptr crashes when the handler receives an event, e.g. a session change notification.
Fixes golang/go#59687