Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language/display: fix Tag method comment #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinms
Copy link
Contributor

@kevinms kevinms commented Feb 18, 2021

Minor fix to comment.

@google-cla
Copy link

google-cla bot commented Feb 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 18, 2021
@kevinms
Copy link
Contributor Author

kevinms commented Feb 18, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 18, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: fd7f650) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/293469 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Marcel van Lohuizen:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carlos Amedee:

Patch Set 1: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Marcel van Lohuizen:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carlos Amedee:

Patch Set 1: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/293469.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 9, 2022
Minor fix to comment.

Change-Id: I181de709f02faf433e97f38208039bf789e6b71d
GitHub-Last-Rev: fd7f650
GitHub-Pull-Request: #19
Reviewed-on: https://go-review.googlesource.com/c/text/+/293469
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Marcel van Lohuizen <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Run-TryBot: Marcel van Lohuizen <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
xhit pushed a commit to xhit/text that referenced this pull request Oct 10, 2022
Minor fix to comment.

Change-Id: I181de709f02faf433e97f38208039bf789e6b71d
GitHub-Last-Rev: fd7f650
GitHub-Pull-Request: golang#19
Reviewed-on: https://go-review.googlesource.com/c/text/+/293469
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Marcel van Lohuizen <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Run-TryBot: Marcel van Lohuizen <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants