gopls/internal: CodeAction: quickfix to generate missing method #528

xzbdmw · 2024-10-05T09:11:54Z

Providing a code action to generate stub methods when encountering
“type X has no field or method Y” error.

extract common functionality about adjusting import,
generating diffs to a shared function.
add new stubMethodsCallFixer (for missing method calls), change
stubMethodsFixer to stubMethodsIfaceFixer(for interfaces)
to make it not vague about which kind of stub it actually be.
My naming is poor...
algos to get type info: for arguments, get type directly,
for return values, currently only implement inferring from variable
assignment and parameter assignment, there seems to be
many different cases, not sure which set to implement.

There is a detailed test that demonstrated this pr.

Fixes golang/go#69692

gopherbot · 2024-10-05T09:17:59Z

This PR (HEAD: c6ebf29) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-05T09:24:39Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-05T09:37:58Z

Message from xxx Lulu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-05T09:58:19Z

This PR (HEAD: 498f74b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-06T09:12:31Z

This PR (HEAD: 164b097) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-06T09:29:31Z

This PR (HEAD: b2156e9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-06T10:06:37Z

This PR (HEAD: 28d6ca0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-06T11:58:35Z

This PR (HEAD: 618f3dd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-06T12:26:38Z

This PR (HEAD: bd6d7e3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-06T12:33:20Z

This PR (HEAD: 4793313) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-06T13:01:41Z

This PR (HEAD: ad593a7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-07T18:40:01Z

Message from Alan Donovan:

Patch Set 11:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-07T21:23:46Z

Message from xxx Lulu:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-07T21:30:43Z

Message from Alan Donovan:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-07T22:48:26Z

This PR (HEAD: 68e660b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-07T23:01:41Z

Message from xxx Lulu:

Patch Set 12:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-07T23:14:56Z

This PR (HEAD: 9fda81b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-07T23:21:32Z

Message from xxx Lulu:

Patch Set 12:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-08T16:01:02Z

This PR (HEAD: 5a3acd9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-08T17:29:58Z

Message from Alan Donovan:

Patch Set 14:

(34 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-09T16:41:13Z

Message from xxx Lulu:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-09T17:09:44Z

Message from xxx Lulu:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T07:44:03Z

This PR (HEAD: 1ab9c55) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-10T07:51:04Z

Message from xxx Lulu:

Patch Set 14:

(36 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-10-10T09:05:59Z

This PR (HEAD: 393f468) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

…f" type error

- move FormatTypeParams from internal/golang/types_format.go to internal/util/typesutil.go - resolve TODO that check if the type is function-local early

name

- postpone param and return type caculation to Emit - add marker test - remove unnecessary test in stub.txt that test local type can not be stubbed

gopherbot · 2024-10-11T04:14:31Z

This PR (HEAD: 0bb1109) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/617619.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-11T04:41:28Z

Message from xxx Lulu:

Patch Set 17:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/617619.
After addressing review feedback, remember to publish your drafts!

xzbdmw force-pushed the missing-method branch from c6ebf29 to 498f74b Compare October 5, 2024 09:52

xzbdmw force-pushed the missing-method branch from 498f74b to 164b097 Compare October 6, 2024 09:06

xzbdmw force-pushed the missing-method branch 2 times, most recently from e60c303 to b2156e9 Compare October 6, 2024 09:28

xzbdmw force-pushed the missing-method branch from b2156e9 to 28d6ca0 Compare October 6, 2024 10:00

xzbdmw force-pushed the missing-method branch from 28d6ca0 to 618f3dd Compare October 6, 2024 11:52

xzbdmw force-pushed the missing-method branch from 618f3dd to bd6d7e3 Compare October 6, 2024 12:20

xzbdmw force-pushed the missing-method branch from bd6d7e3 to 4793313 Compare October 6, 2024 12:32

xzbdmw force-pushed the missing-method branch from 4793313 to ad593a7 Compare October 6, 2024 13:00

xzbdmw force-pushed the missing-method branch from 1ab9c55 to 393f468 Compare October 10, 2024 08:59

xzbdmw added 4 commits October 11, 2024 11:14

feature: code action to generate a stub function from a "no function …

f036227

…f" type error

resolve suggestions

00318e2

- move FormatTypeParams from internal/golang/types_format.go to internal/util/typesutil.go - resolve TODO that check if the type is function-local early

identTrail, turn Uppercase Type name into last section lower case param

557ee89

name

Add Document

cac52c7

xzbdmw force-pushed the missing-method branch from 393f468 to 2a9e003 Compare October 11, 2024 04:12

resolve suggestions

0bb1109

- postpone param and return type caculation to Emit - add marker test - remove unnecessary test in stub.txt that test local type can not be stubbed

xzbdmw force-pushed the missing-method branch from 2a9e003 to 0bb1109 Compare October 11, 2024 04:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gopls/internal: CodeAction: quickfix to generate missing method #528

gopls/internal: CodeAction: quickfix to generate missing method #528

xzbdmw commented Oct 5, 2024 •

edited

Loading

gopherbot commented Oct 5, 2024

gopherbot commented Oct 5, 2024

gopherbot commented Oct 5, 2024

gopherbot commented Oct 5, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 8, 2024

gopherbot commented Oct 8, 2024

gopherbot commented Oct 9, 2024

gopherbot commented Oct 9, 2024

gopherbot commented Oct 10, 2024

gopherbot commented Oct 10, 2024

gopherbot commented Oct 10, 2024

gopherbot commented Oct 11, 2024

gopherbot commented Oct 11, 2024

gopls/internal: CodeAction: quickfix to generate missing method #528

Are you sure you want to change the base?

gopls/internal: CodeAction: quickfix to generate missing method #528

Conversation

xzbdmw commented Oct 5, 2024 • edited Loading

gopherbot commented Oct 5, 2024

gopherbot commented Oct 5, 2024

gopherbot commented Oct 5, 2024

gopherbot commented Oct 5, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 6, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 7, 2024

gopherbot commented Oct 8, 2024

gopherbot commented Oct 8, 2024

gopherbot commented Oct 9, 2024

gopherbot commented Oct 9, 2024

gopherbot commented Oct 10, 2024

gopherbot commented Oct 10, 2024

gopherbot commented Oct 10, 2024

gopherbot commented Oct 11, 2024

gopherbot commented Oct 11, 2024

xzbdmw commented Oct 5, 2024 •

edited

Loading