Skip to content

Commit

Permalink
ESCOMP tag: cam6_4_017
Browse files Browse the repository at this point in the history
Merge pull request ESCOMP#1112 from brian-eaton/misc03

cam6_4_017: fix issues ESCOMP#1087 and ESCOMP#1103

ESCOMP commit: d723056
  • Loading branch information
brian-eaton authored and Steve Goldhaber committed Oct 16, 2024
1 parent e1df6d1 commit b7f8956
Showing 1 changed file with 73 additions and 0 deletions.
73 changes: 73 additions & 0 deletions doc/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,78 @@
===============================================================

Tag name: cam6_4_017
Originator(s): eaton
Date: 30 July 2024
One-line Summary: miscellaneous fixes
Github PR URL: https://github.com/ESCOMP/CAM/pull/1112

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

Fixes for:
Issue #1087 - Prevent users from turning on OpenMP when using the SE dycore
Issue #1103 - Bug with physprops files for mam4_mode3 for RRTMGP

Describe any changes made to build system:
. add check in CAM's configure to fail if SMP is specified with the SE dycore.

Describe any changes made to the namelist:
. fix attributes in namelist defaults to get the correct physprops file for
mam4_mode3 with RRTMGP

List any changes to the defaults for the boundary datasets: none

Describe any substantial timing or memory changes: none

Code reviewed by: cacraig

List all files eliminated: none

List all files added and what they do: none

List all existing files that have been modified, and describe the changes:

bld/configure
. If smp is on and the dycore is SE, issue message and exit.

bld/namelist_files/namelist_defaults_cam.xml
. add missing phys="cam6" attribute so cam7 runs get the correct version of
mam4_mode3_file for rrtmgp

If there were any failures reported from running test_driver.sh on any test
platform, and checkin with these failures has been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

derecho/intel/aux_cam:
ERP_D_Ln9.ne30pg3_ne30pg3_mg17.FLTHIST.derecho_intel.cam-outfrq9s_rrtmgp (Overall: DIFF) details:
. diff due to updating the mam4_mode3 physprop file

ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
- pre-existing failure due to HEMCO not having reproducible results issues #1018 and #856

SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s (Overall: PEND) details:
SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: PEND) details:
- pre-existing failures -- need fix in CLM external

SMS_D_Ln9.T42_T42.FSCAM.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
- pre-existing failure -- need fix in CICE external

izumi/nag/aux_cam:

DAE.f45_f45_mg37.FHS94.izumi_nag.cam-dae (Overall: FAIL) details:
- pre-existing failure - issue #670

izumi/gnu/aux_cam: All PASS

CAM tag used for the baseline comparison tests if different than previous
tag:

Summarize any changes to answers: BFB except cam7/rrtmgp configurations
have different answers due to changing the mam4_mode3 physprops file.

===============================================================
===============================================================

Tag name: cam6_4_016
Originator(s): brianpm, eaton
Date: 25 July 2024
Expand Down

0 comments on commit b7f8956

Please sign in to comment.