Use @golemcloud org + Config improvements #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburniske
commented
Jun 14, 2024
| @@ -20,15 +20,18 @@ import type { Result } from "./result"; | |||
| * @param input | |||
| * @param init | |||
| */ | |||
| function fetchSync(input: RequestInfo | URL, init?: RequestInit): Response { | |||
There was a problem hiding this comment.
changes to types here to be compatible with node types
nicoburniske
commented
Jun 14, 2024
| "lib": ["es2020", "dom"] | ||
| "lib": ["es2020"], | ||
| "types": ["node"], | ||
| "moduleResolution": "Node" |
There was a problem hiding this comment.
removed dom from lib (because we are not running in browser) and set moduleResolution to Node
nicoburniske
commented
Jun 14, 2024
| "enabled": true, | ||
| "lineWidth": 100, | ||
| "indentStyle": "space", | ||
| "indentWidth": 3 |
There was a problem hiding this comment.
indentWidth 3 -> 4
noise64
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golem-tsto@golemcloud/golem-tstsconfig.jsonto use node types instead of includingdomin lib array