-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web UI for managing Golem #1195
Conversation
Golem macos exexutable can be found here https://drive.google.com/drive/folders/1lrbZsLgdb0d_Q8xvqrQ6QuMRq1ZIUqwC, How it worksA new service is created called golem-ui-service, this service has an axum server and a react/TS project AssetsThe frontend assets are added to the golem executable using rust-embed UsageThe UI server can be switched on by running
Buildingrun |
Thanks for submitting your proposed solution to #1189! I have not reviewed the code very closely, because first the UI must be in a state where it meets the requirements for the ticket. Once the UI meets the requirements, I will proceed to perform a code review, which may ask for additional revisions. Overall, I want to congratulate you on so quickly developing a user-interface for the REST API! It was easy for me to find my way around the user-interface, and for the most part, it feels snappy an modern. Great job! Now, I have to say the UI still need a lot of work before I can consider merging it. Let me review the main areas:
There are a number of other missing features and usability improvements that are required, but I will wait until if and when you decide to address these issues. I do think the pull request can be pushed forward to completion, but what I strongly recommend is building a TODO app in one of the Golem-supported languages, including with a full REST API and simple UI served by the backend. Once you write the code, force yourself to upload the component, create all API definitions, and serve the static content, using only the front-end you built. This will force you to add missing features and fix bugs that will end up making the UI production-ready and mergeable (right now, though a promising start, the UI is not really production-ready and does not replicate or extend upon the features of Console). Please re-open when you get a chance to work on these issues! |
Hello @jdegoes |
/claim #1189