-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamic resource parameters in Rib #960
Merged
Merged
Changes from 25 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
68e651d
Support dynamic resource parameters in Rib
afsalthaj ed7ebe7
Bring grpc types
afsalthaj a7e907c
Add IR proto
afsalthaj 385bec7
Add more rib
afsalthaj caadf4c
Add type
afsalthaj 2ff4124
Add Expr
afsalthaj 4bf530a
Add Expr
afsalthaj 486d07e
Fix test cases
afsalthaj 318b48a
Try to fix function name
afsalthaj 632e910
Fix tests
afsalthaj a538b65
Reformat
afsalthaj 1fc4453
Fix clippy
afsalthaj 9d14333
Refactor
afsalthaj e833175
Merge branch 'main' into dynamic_resource_parameters
afsalthaj ae3058b
Use function name
afsalthaj e4d8f15
Merge remote-tracking branch 'origin/dynamic_resource_parameters' int…
afsalthaj 74d8945
Write test for indexed function
afsalthaj 5f69c0c
Make sure resource params are created
afsalthaj 39ff6ed
Merge branch 'main' into dynamic_resource_parameters
afsalthaj d91f000
Delete comments
afsalthaj 287cc72
Merge remote-tracking branch 'origin/dynamic_resource_parameters' int…
afsalthaj 44d13a4
Remove clone
afsalthaj f10154f
Reformat code
afsalthaj 07bbf7e
Add more tests
afsalthaj 2ffcfff
Add more tests
afsalthaj ab98630
Remove the need of serde for RibByteCode
afsalthaj 6149dd4
Use field names in instruction set instead of anonymouse types
afsalthaj 170dbcf
Check if its part of resource than indexed_resource
afsalthaj 3eeeb3a
Merge branch 'main' into dynamic_resource_parameters
afsalthaj 528bb79
Make grpc types backward compatible
afsalthaj 22e2702
Merge remote-tracking branch 'origin/dynamic_resource_parameters' int…
afsalthaj 61d3b82
Reformat code
afsalthaj eb2f113
Add tests
afsalthaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how? These are grpc types only for internal persistence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, discard my question. In terms of backward compatibility, well the function name is different now because has
Exprs
in it, and it's a different structure. I need to test backward compatibility.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is internal persistence? If it is stored in any database, then this is a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to test/fix backward compatibility , which is what is remaining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way to handle this would be to detect breakage and recompile from source. Since the IR is not exposed to the user.