Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ya-runtime-vm adding optional -device param to vmrt #165

Merged
merged 25 commits into from
Jul 20, 2023

Conversation

pwalski
Copy link
Contributor

@pwalski pwalski commented Jun 16, 2023

Resolves: https://github.com/golemfactory/golem-internal/issues/647

Todo:

  • sync with ya-runtime-vm master
  • Remove pci devices list related code (it will be done by self-test-img)
  • Implement adding !exp:gpu capability based on self-test-img output
  • Move changes in qemu Dockerfile to dedicated repository where it will be build together with gpu dedicated vmlinuz
  • Create CI for /golemfactory/ya-runtime-vm-gpu which takes binary of configurable ya-runtime-vm release, builds qemu, and vmlinuz and publishes it as an ya-runtimve-vm-gpu release (it will still require installation script which will generate runtime dedscriptor)
  • Implement adding optional --device Qemu param configurable by runtime-vm cmdline --pci-device param in runtime descriptor extra-args field.

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kamirr
✅ pwalski
❌ norbibi
You have signed the CLA already but the status is still pending? Let us recheck it.

@pwalski pwalski force-pushed the master branch 2 times, most recently from eb9ccfd to 9bb577e Compare June 16, 2023 16:18
@pwalski
Copy link
Contributor Author

pwalski commented Jun 16, 2023

qemu build moved to https://github.com/golemfactory/ya-runtime-vm-gpu

@pwalski pwalski marked this pull request as ready for review July 19, 2023 08:06
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: nieznanysprawiciel <[email protected]>
@pwalski
Copy link
Contributor Author

pwalski commented Jul 20, 2023

In case of approve do not merge it - need to check last time everything on GPU host before merge.

@pwalski pwalski merged commit 96c19ea into golemfactory:master Jul 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants