Skip to content

Commit

Permalink
to_asyncio: mask error logging, not sure it adds that much
Browse files Browse the repository at this point in the history
  • Loading branch information
goodboy committed Sep 26, 2023
1 parent 3dc57e3 commit 3a31c9d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tractor/to_asyncio.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ async def wait_on_coro_final_result(
try:
result = await coro
except BaseException as aio_err:
log.exception('asyncio task errored')
# log.exception('asyncio task errored:')
chan._aio_err = aio_err
raise

Expand Down Expand Up @@ -300,7 +300,7 @@ def cancel_trio(task: asyncio.Task) -> None:
elif task_err is None:
assert aio_err
aio_err.with_traceback(aio_err.__traceback__)
log.error('infected task errorred')
# log.error('infected task errorred')

# XXX: alway cancel the scope on error
# in case the trio task is blocking
Expand Down Expand Up @@ -356,7 +356,7 @@ def maybe_raise_aio_err(
# relay cancel through to called ``asyncio`` task
assert chan._aio_task
chan._aio_task.cancel(
msg=f'the `trio` caller task was cancelled: {trio_task.name}'
msg=f'`trio`-side caller task cancelled: {trio_task.name}'
)
raise

Expand All @@ -366,7 +366,7 @@ def maybe_raise_aio_err(
trio.ClosedResourceError,
# trio.BrokenResourceError,
):
aio_err = chan._aio_err
aio_err: BaseException = chan._aio_err
if (
task.cancelled() and
type(aio_err) is CancelledError
Expand Down

0 comments on commit 3a31c9d

Please sign in to comment.