Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JAX implementation of CFR #1175

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Added JAX implementation of CFR #1175

merged 4 commits into from
Apr 22, 2024

Conversation

kubicon
Copy link
Contributor

@kubicon kubicon commented Feb 5, 2024

Implementation of CFR that uses JAX. This allows running CFR with GPU acceleration. Speed up over python CFR implementation is ~10-times on CPU only.

The goal was to make it interchangable with the python CFR.

Copy link

google-cla bot commented Feb 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lanctot
Copy link
Collaborator

lanctot commented Feb 5, 2024

Hi, thanks for the PR!

The reason the wheel tests are failing is because you need an empty init.py file in evert directory. Your new one is missing it. Can you add it?

(Don't forget the license header even if the file is empty .. e.g. just copy one of the other ones)

@kubicon
Copy link
Contributor Author

kubicon commented Feb 6, 2024

Hey,
I am sorry. Did not realize that init.py was important. However, it should be there now. Hopefully everything will work fine now

@lanctot lanctot added ready to import Ready to import imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Apr 16, 2024
@lanctot lanctot merged commit 0086b44 into google-deepmind:master Apr 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. ready to import Ready to import
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants