Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to CI workflow scripts #1200

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Updates to CI workflow scripts #1200

merged 9 commits into from
Apr 8, 2024

Conversation

lanctot
Copy link
Collaborator

@lanctot lanctot commented Apr 6, 2024

  • Github Actions migrate to node.js 20: upgrade version of checkout and upload-artifact to v4
  • Remove (macos-11, Python3.8), add (macos-13, Python3.11)

@lanctot lanctot changed the title Github Actions migrate to node.js 20: upgrade version of checkout and upload-artifact to v4 Updates to workflow scripts Apr 7, 2024
@lanctot lanctot changed the title Updates to workflow scripts Updates to CI workflow scripts Apr 7, 2024
@lanctot
Copy link
Collaborator Author

lanctot commented Apr 7, 2024

Waiting for later to move to macos-14, which uses Python 3.12.

See the error below, which occurred on macos-14: it also requires venv like most recent Linux distros.

Will do this in the upcoming Python 3.12 PR. This script should no longer be using get-pip.py. So, will have to modify the CI / install scripts.

++ python3 --version
Python 3.12.2
+++ which clang++
++ [[ -x /usr/bin/clang++ ]]
+++ which curl
++ [[ -x /usr/bin/curl ]]
++ [[ OFF == \O\N ]]
++ [[ OFF == \O\N ]]
++ curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 67 2574k   67 1745k    0     0  14.9M      0 --:--:-- --:--:-- --:--:-- 14.9M
100 2574k  100 2574k    0     0  20.2M      0 --:--:-- --:--:-- --:--:-- 20.1M
++ python3 get-pip.py
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try brew install
    xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-brew-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip.
    
    If you wish to install a non-brew packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Apr 8, 2024
@lanctot lanctot merged commit 62ee37c into master Apr 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant