-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Middle-Eastern dominoes as independent game #1211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
A few quick things:
Can you add the test to the Python CMakeLists.txt ([here](Here:
open_spiel/open_spiel/python/CMakeLists.txt
Line 218 in e5d1f09
games/block_dominoes_test.py |
so that it runs on Github Actions CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you add it to the list of games pyspiel_test.py here:
"python_block_dominoes", |
(That is needed for general simulation tests and to check the list of games matches what is registered.)
I think it's fine as a separate game since they were developed separately and also it means the complexity of each game doesn't get out of hand with all the handling of separate logic cases for each variant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the game to the games list?
This one: https://github.com/google-deepmind/open_spiel/blob/master/docs/games.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the boilerplate code and made a few changes to the references (the Middle Eastern version is slightly different from the Latin American version so I referenced the latter).
Ok, thanks. I have now triggered the tests on Github Actions. If this is a specific variant of the more popular game, we should probably not call it just |
You're right, and I like On a separate note, I'm now trying to work on training the best possible agent based on available OpenSpiel algorithms (or expand to other algorithms if necessary). Due to the size of the game, I'm a bit overwhelmed as to how to go about this process. Do you have any tips/resources that could be useful? I developed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated name to team_dominoes
.
Added 2v2 dominoes, also known as ME dominoes, to the repo as an independent game.
The current PR could be modified so that this is just a separate configuration of block dominoes instead of a whole new game. The game implementations vary sufficiently as to require different
State
classes in my opinion, but it could be done in a manner similar totiny_bridge
.If this second course of action is suggested, I would appreciate advice on how to implement it correctly according to OpenSpiel's guidelines.