[BUG FIX} fixed small positional argument bug #1231
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: Jax implementation of DQN wouldn't work for buffer size >= 1000 (min buffer size for learning) because of small bug in line 282.
open_spiel/open_spiel/python/jax/dqn.py", line 282, in _loss max_next_q = jax.numpy.where( TypeError: where() got some positional-only arguments passed as keyword arguments: 'x, y' (.venv) brunozorrilla:.../GitHub/open_spiel$
Solution: get rid keyword of arguments: