Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cfr and cfr+ docstring for average policy #1296

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix cfr and cfr+ docstring for average policy #1296

merged 1 commit into from
Dec 16, 2024

Conversation

ryan-dorazio
Copy link
Contributor

The wrong method is mentioned in the docstring to access the average policy in the python implementation of CFR and CFR+.

@lanctot
Copy link
Collaborator

lanctot commented Dec 5, 2024

Thanks!

@lanctot
Copy link
Collaborator

lanctot commented Dec 5, 2024

Hi @ryan-dorazio

There was a problem on our end with the Github Actions CI tests.

Can you pull changes from master and push the merge commit to trigger the CI tests again?

@lanctot
Copy link
Collaborator

lanctot commented Dec 5, 2024

Oh wait, this is just a change to docs -- should not be necessary.

@lanctot lanctot added documentation Improvements or additions to documentation imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Dec 5, 2024
@lanctot lanctot merged commit 7c1db4f into google-deepmind:master Dec 16, 2024
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-dorazio @lanctot