New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RoPE theta in config #102

Merged

danieldjohnson merged 1 commit into google-deepmind:main from Fedzbar:main

Dec 15, 2024

Contributor

Fedzbar commented Dec 7, 2024 •

edited

Loading

Hello,

Thanks for the great library!

I believe there is a bug with the conversion of Llama models when it comes to the RoPE wavelength.

This is quite important as the theta is set to 500k in the new Llama models, while this was hardcoded to 10k.

Thanks!
Federico


          Fix RoPE theta in config

397df71

danieldjohnson merged commit e23bfed into google-deepmind:main

2 checks passed

Collaborator

danieldjohnson commented Dec 15, 2024

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet