Remove node-hyperlink and copypaste-fallback support, tweak path copying. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…ing. Removes two complex features in Treescope which were only rarely used: - Node hyperlinks: Previously, tree nodes could link to each other by path. However, this added complexity to every rendering and is unused in the v2 Penzai neural network design. - Copypaste fallbacks: To try to ensure Treescope renderings were valid Python syntax even for unrecognized types, custom `repr` implementations were originally wrapped in a "NotRoundtrippable" wrapper in roundtrip mode. However, this was only partially supported and cannot be guaranteed now that types can define their own Treescope handlers. Penzai models are still roundtrippable if they don't have array data. Also changes the "Copy path" buttons to be less verbose, by removing the "(lambda root: root...)" boilerplate. PiperOrigin-RevId: 653597261
copybara-service
bot
force-pushed
the
test_651758769
branch
from
4dc99dd to
2b7d0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove node-hyperlink and copypaste-fallback support, tweak path copying.
Removes two complex features in Treescope which were only rarely used:
added complexity to every rendering and is unused in the v2 Penzai neural network design.
for unrecognized types, custom
reprimplementations were originally wrapped in a"NotRoundtrippable" wrapper in roundtrip mode. However, this was only partially supported
and cannot be guaranteed now that types can define their own Treescope handlers. Penzai
models are still roundtrippable if they don't have array data.
Also changes the "Copy path" buttons to be less verbose, by removing the "(lambda root: root...)"
boilerplate.