Use clang toolchain to building manylinux2014 wheels #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TensorFlow > 2.13.0 starts using clang for building the release wheels. Update the Reverb to use clang as well.
ddmbr
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorFlow > 2.13.0 starts using clang for building the release wheels. Reverb and Launchpad are still using
GCC, which may potentially encounter ABI compatibility issues. See e.g., pybind/pybind11_abseil#12
This PR updates Reverb to use clang as well. The toolchain configuration is obtained from running the TensorFlow repository with the release_cpu_linux config and then applying some manual modification.
I have to disable errors at the moment (see .bazelrc) as clang otherwise complains about building some of the dependencies (BoringSSL and UPB). Disabling the specific warnings does not seem to work at the moment but maybe I just didn't know how to set them properly in Bazel.