-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog requirement action for major/minor bumps #174
Conversation
When running the task locally from within this branch I get
Is this expected? |
Like the check for API changes task, there needs to be context for what API state to compare against. The action sets up the previous state to be the target branch, the local state may vary. |
What I'm trying to verify is if the task : a) correctly identifies the expected version bump My local state is: it's a new repo clone with no local changes. Under these conditions, is the major version warning message expected? |
Yes, I believe it's diffing an empty API with the modern API, which will always be major. For local testing, you'd need to run |
You're right. Running |
…#174) "Warn Version Bump" will fail if a PR contains a major/minor bump without a changelog. There most recent test commits show what this failure looks like.
…#174) "Warn Version Bump" will fail if a PR contains a major/minor bump without a changelog. There most recent test commits show what this failure looks like.
"Warn Version Bump" will fail if a PR contains a major/minor bump without a changelog. There most recent test commits show what this failure looks like.