-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation snippets to the repo #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java samples are still missing
No actual snippets yet.
No snippets yet
Using google-java-format tool
This enables us to compile them and be sure they work.
Using the ktfmt tool
These files shouldn't be created by hand by developers
rachelsaunders
suggested changes
Jun 24, 2024
samples/src/main/java/com/google/ai/client/generative/samples/java/chat.java
Outdated
Show resolved
Hide resolved
MarkDaoust
reviewed
Jun 24, 2024
samples/src/main/java/com/google/ai/client/generative/samples/count_tokens.kt
Outdated
Show resolved
Hide resolved
MarkDaoust
reviewed
Jun 24, 2024
samples/src/main/java/com/google/ai/client/generative/samples/system_instructions.kt
Outdated
Show resolved
Hide resolved
andrewheard
reviewed
Jun 26, 2024
samples/src/main/java/com/google/ai/client/generative/samples/text_generation.kt
Outdated
Show resolved
Hide resolved
The prompts were missing the actual images.
There were warnings about unused variables, and errors due to missing imports.
friendly ping @rachelsaunders |
thatfiredev
reviewed
Jul 5, 2024
This prevents the code from being seeing under normal circunstances in Android Studio
Co-authored-by: David Motsonashvili <[email protected]>
rachelsaunders
approved these changes
Jul 11, 2024
ryanwilson
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for approval
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Internal b/346393026 --------- Co-authored-by: rachelsaunders <[email protected]> Co-authored-by: David Motsonashvili <[email protected]> Co-authored-by: David Motsonashvili <[email protected]>
PatilShreyas
pushed a commit
to PatilShreyas/generative-ai-kmp
that referenced
this pull request
Sep 21, 2024
Internal b/346393026 --------- Co-authored-by: rachelsaunders <[email protected]> Co-authored-by: David Motsonashvili <[email protected]> Co-authored-by: David Motsonashvili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal b/346393026