Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proguard): keep enum members classes #31

Closed
wants to merge 2 commits into from

Conversation

iurysza
Copy link

@iurysza iurysza commented Jan 2, 2024

Summary

This PR addresses issue #29, which caused consumer apps to crash when using the library in release mode.

Issue Details

Without this rule you get this when the consumer app has Proguard/R8 minification enabled:

Caused by: java.lang.NoSuchFieldException: UNKNOWN
  at java.lang.Class.getField(Class.java:2337)
  at com.google.ai.client.generativeai.internal.util.FirstOrdinalSerializer.deserialize(SourceFile:2)
  at com.google.ai.client.generativeai.internal.api.server.FinishReasonSerializer.deserialize

Copy link

google-cla bot commented Jan 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@iurysza
Copy link
Author

iurysza commented Jan 2, 2024

Sry, I guess this was already addressed in #23

@iurysza iurysza closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant