Refactor data export to separate component #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the dialog window with data export output into a separate component, to - de-clutter the prefetch table from additional functionality, and - allow reuse by precache analysis in the future. Also moves the export type selection into the new DataExport component.
Decouples the generation of export output from the DataExport view logic to display export options and output.
Adds a tab bar navigation in data export and empty state to allow easy extension of export types (CSV is planned).
aymanfarhat
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the data export logic from PrefetchTable into its own DataExport component, to separate concerns and de-clutter the overloaded PrefetchTable component for better maintainability. This also prepares usage of the DataExport component for precache analysis and will make adjustments easier in the future.
Lint and tests have run successfully.