Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#471 Proper user has canceled login error code. #472

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

Romick2005
Copy link
Contributor

This should fix #471 and related issue #1327 in react-native-google-signin.

Copy link

google-cla bot commented Sep 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@brnnmrls brnnmrls self-requested a review September 9, 2024 21:34
@brnnmrls
Copy link
Member

brnnmrls commented Sep 9, 2024

Please resolve this comment

@brnnmrls
Copy link
Member

brnnmrls commented Oct 1, 2024

My apologies for the delay, do you mind updating the branch to include changes from the main branch please?

@Romick2005
Copy link
Contributor Author

My apologies for the delay, do you mind updating the branch to include changes from the main branch please?

Sure. Ready to merge ).

@brnnmrls brnnmrls merged commit 4a17a8d into google:main Oct 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid error code have been thrown: kGIDSignInErrorCodeUnknown, but should be kGIDSignInErrorCodeCanceled
2 participants