Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception if verified age scope is passed in sign-in request through the add scopes flow. #473

Merged
merged 13 commits into from
Sep 11, 2024

Conversation

brnnmrls
Copy link
Member

@brnnmrls brnnmrls commented Sep 4, 2024

If a developer passes verification age scope to addScopes method, this results in an error (invalid_request). Instead of having the developer run through documentation and figure out why it errors, we'll throw an exception to let the developer know to use GIDVerifyAccountDetail instead.

@brnnmrls brnnmrls self-assigned this Sep 4, 2024
@brnnmrls brnnmrls marked this pull request as ready for review September 4, 2024 17:43
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDRestrictedScopesRegistry.h Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDRestrictedScopesRegistry.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDRestrictedScopesRegistryTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
@brnnmrls brnnmrls merged commit ae6faa9 into briannamorales/vwg-flow Sep 11, 2024
13 checks passed
@brnnmrls brnnmrls deleted the briannamorales/testValidScopes branch September 11, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants