Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insets] Remove library from Accompanist #1685

Merged
merged 3 commits into from
Jul 27, 2023
Merged

[Insets] Remove library from Accompanist #1685

merged 3 commits into from
Jul 27, 2023

Conversation

bentrengrove
Copy link
Collaborator

Insets has been deprecated for multiple releases now so I am removing it completely from the repository.

I will leave the guide up for now in case people click the link, probably one more release.

Copy link
Collaborator

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And so the cycle for insets is (almost) complete! 🎉

A couple minor requests, and can we remove the insets issue template as well?
https://github.com/google/accompanist/blob/main/.github/ISSUE_TEMPLATE/insets-bug-report.md

.idea/migrations.xml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
permissions-lint/lint-report.html Outdated Show resolved Hide resolved
@bentrengrove
Copy link
Collaborator Author

All fixed!

Copy link
Collaborator

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bentrengrove bentrengrove merged commit 8eefcee into main Jul 27, 2023
9 checks passed
@bentrengrove bentrengrove deleted the insets_remove branch July 27, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants