Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tests: disable batching in gold tests on Android
setRequestedOrientation from a previous trace appears to affect pixels. We often see this on CI when a new trace is added which reshuffles traces. For example, in this sequence the first trace sets landscape orientation and the second one goes back to portrait: angle_trace_tests --gtest_filter=TraceTest.dota_underlords:TraceTest.dragon_raja \ --run-to-key-frame --save-screenshots --verbose \ --render-test-output-dir=/tmp/g When the second trace is run independently, the resulting pixels are slightly different. This CL disables batching tests on Android so each trace runs as a new instrumentation/activity. This way the previous trace orientation does not seem to matter. The impact on shard runtime seems minor. Bug: b/367401313 Change-Id: If1c41e45d063d434f92d46be8dd381e645a3ff0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5866850 Reviewed-by: Cody Northrop <[email protected]> Reviewed-by: Yuly Novikov <[email protected]> Commit-Queue: Roman Lavrov <[email protected]>
- Loading branch information