Skip to content

Commit

Permalink
Vulkan: Get rid of X11 include in DisplayVkXcb.cpp
Browse files Browse the repository at this point in the history
Bug: angleproject:8520
Change-Id: Iaa251b0ba2858873b8d22e8f9e5dae7a2567c95e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5273489
Reviewed-by: Geoff Lang <[email protected]>
Auto-Submit: Shahbaz Youssefi <[email protected]>
Commit-Queue: Shahbaz Youssefi <[email protected]>
Commit-Queue: Geoff Lang <[email protected]>
  • Loading branch information
ShabbyX authored and Angle LUCI CQ committed Feb 6, 2024
1 parent 98d3f32 commit 8abbe28
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ angle_static_library("angle_gpu_info_util") {
if (angle_use_x11 && angle_has_build) {
sources += libangle_gpu_info_util_x11_sources
deps += [ "src/third_party/libXNVCtrl:libXNVCtrl" ]
libs += [ "xcb-util" ]
defines += [ "GPU_INFO_USE_X11" ]
libs += [
"X11",
Expand Down
2 changes: 1 addition & 1 deletion src/libANGLE/renderer/gl/glx/DisplayGLX.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ egl::Error DisplayGLX::waitClient(const gl::Context *context)

egl::Error DisplayGLX::waitNative(const gl::Context *context, EGLint engine)
{
// eglWaitNative is used to notice the driver of changes in X11 for the current surface, such as
// eglWaitNative is used to notify the driver of changes in X11 for the current surface, such as
// changes of the window size. We use this event to update the child window of WindowSurfaceGLX
// to match its parent window's size.
// Handling eglWaitNative this way helps the application control when resize happens. This is
Expand Down
4 changes: 2 additions & 2 deletions src/libANGLE/renderer/vulkan/linux/xcb/DisplayVkXcb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

#include "libANGLE/renderer/vulkan/linux/xcb/DisplayVkXcb.h"

#include <X11/Xutil.h>
#include <xcb/xcb.h>
#include <xcb/xcb_aux.h>

#include "common/system_utils.h"
#include "libANGLE/Display.h"
Expand Down Expand Up @@ -157,7 +157,7 @@ DisplayImpl *CreateVulkanXcbDisplay(const egl::DisplayState &state)

angle::Result DisplayVkXcb::waitNativeImpl()
{
XSync(reinterpret_cast<Display *>(mState.displayId), False);
xcb_aux_sync(mXcbConnection);
return angle::Result::Continue;
}
} // namespace rx

0 comments on commit 8abbe28

Please sign in to comment.