Enable VariantAnimationTimelineTest and add protobuf-kotlin-lite depe…

…ndency This change re-enables the VariantAnimationTimelineTest, which was previously disabled. It also adds the protobuf-kotlin-lite dependency to the validation build.
google · Jan 10, 2025 · c3a3cf3 · c3a3cf3
1 parent c47e911
commit c3a3cf3
Show file tree

Hide file tree

Showing 15 changed files with 2 additions and 8 deletions.
diff --git a/integration-tests/validation/build.gradle.kts b/integration-tests/validation/build.gradle.kts
@@ -92,6 +92,7 @@ dependencies {
     implementation(libs.androidx.media3.exoplayer)
     implementation(libs.androidx.media3.exoplayer.dash)
     implementation(libs.androidx.media3.ui)
+    implementation(libs.protobuf.kotlin.lite)
 
     debugImplementation(libs.androidx.compose.ui.tooling)
     debugImplementation(libs.androidx.compose.ui.test.manifest)

diff --git a/...lidation/src/main/assets/figma/VariantAnimationTimelineTestDoc_vJRf4zxY4QX4zzSSUd1nJ5.dcf b/...lidation/src/main/assets/figma/VariantAnimationTimelineTestDoc_vJRf4zxY4QX4zzSSUd1nJ5.dcf
diff --git a/...dation/src/main/java/com/android/designcompose/testapp/validation/examples/AllExamples.kt b/...dation/src/main/java/com/android/designcompose/testapp/validation/examples/AllExamples.kt
@@ -133,10 +133,7 @@ val EXAMPLES: ArrayList<Triple<String, @Composable () -> Unit, String?>> =
         // Animations
         Triple("SA", { SmartAnimateTest() }, SmartAnimateTestDoc.javaClass.name),
         Triple("SA Variant", { VariantAnimationTest() }, VariantAnimationTestDoc.javaClass.name),
-        /**
-         * Temporarily disabled: GH-1945 Triple( "SA Variant Timelines", {
-         * VariantAnimationTimelineTest() }, VariantAnimationTimelineTestDoc.javaClass.name, ),
-         */
+         Triple( "SA Variant Timelines", { VariantAnimationTimelineTest() }, VariantAnimationTimelineTestDoc.javaClass.name),
         // No support for hyperlinks in squoosh.
         Triple("Hyperlink", { HyperlinkTest() }, HyperlinkValidationDoc.javaClass.name),
         // GH-636: Test takes too long to execute.

diff --git a/...les/VariantAnimationTimelineTest.DISABLED → .../examples/VariantAnimationTimelineTest.kt b/...les/VariantAnimationTimelineTest.DISABLED → .../examples/VariantAnimationTimelineTest.kt
@@ -15,7 +15,6 @@
  */
 
 package com.android.designcompose.testapp.validation.examples
-/** Temporarily disabled: GH-1945
 
 import androidx.compose.animation.core.CubicBezierEasing
 import androidx.compose.animation.core.tween
@@ -213,4 +212,3 @@ fun VariantAnimationTimelineTest() {
         }
     }
 }
- */
diff --git a/...pp/validation/AnimationTimelines.DISABLED → .../testapp/validation/AnimationTimelines.kt b/...pp/validation/AnimationTimelines.DISABLED → .../testapp/validation/AnimationTimelines.kt
@@ -15,7 +15,6 @@
  */
 
 package com.android.designcompose.testapp.validation
-/** Temporarily disabled: GH-1945
 
 import androidx.activity.ComponentActivity
 import androidx.compose.ui.test.junit4.createAndroidComposeRule
@@ -109,4 +108,3 @@ class AnimationTimelines {
         composeTestRule.captureRootRoboImage("${name}Animation-End")
     }
 }
- */
diff --git a/...ion/src/testDebug/roborazzi/AnimationTimelines/ChildCustomAnimAnimation-End.png b/...ion/src/testDebug/roborazzi/AnimationTimelines/ChildCustomAnimAnimation-End.png
diff --git a/...rc/testDebug/roborazzi/AnimationTimelines/ChildCustomAnimAnimation-MidPoint.png b/...rc/testDebug/roborazzi/AnimationTimelines/ChildCustomAnimAnimation-MidPoint.png
diff --git a/...n/src/testDebug/roborazzi/AnimationTimelines/ChildCustomAnimAnimation-Start.png b/...n/src/testDebug/roborazzi/AnimationTimelines/ChildCustomAnimAnimation-Start.png
diff --git a/.../src/testDebug/roborazzi/AnimationTimelines/DifferentDurationsAnimation-End.png b/.../src/testDebug/roborazzi/AnimationTimelines/DifferentDurationsAnimation-End.png
diff --git a/...testDebug/roborazzi/AnimationTimelines/DifferentDurationsAnimation-MidPoint.png b/...testDebug/roborazzi/AnimationTimelines/DifferentDurationsAnimation-MidPoint.png
diff --git a/...rc/testDebug/roborazzi/AnimationTimelines/DifferentDurationsAnimation-Start.png b/...rc/testDebug/roborazzi/AnimationTimelines/DifferentDurationsAnimation-Start.png
diff --git a/...validation/src/testDebug/roborazzi/AnimationTimelines/OneByOneAnimation-End.png b/...validation/src/testDebug/roborazzi/AnimationTimelines/OneByOneAnimation-End.png
diff --git a/...ation/src/testDebug/roborazzi/AnimationTimelines/OneByOneAnimation-MidPoint.png b/...ation/src/testDebug/roborazzi/AnimationTimelines/OneByOneAnimation-MidPoint.png
diff --git a/...lidation/src/testDebug/roborazzi/AnimationTimelines/OneByOneAnimation-Start.png b/...lidation/src/testDebug/roborazzi/AnimationTimelines/OneByOneAnimation-Start.png
diff --git a/...s/validation/src/testDebug/roborazzi/RenderAllExamples/SA-Variant-Timelines.png b/...s/validation/src/testDebug/roborazzi/RenderAllExamples/SA-Variant-Timelines.png