Delete the no-longer-necessary proto utils #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2024
timothyfroehlich
force-pushed
the
wb/froeht/protolize-dcf
branch
from
4a74387 to
5f39a3b
Compare
timothyfroehlich
force-pushed
the
wb/froeht/delete-proto-utils
branch
from
a44231a to
c823e91
Compare
Base automatically changed from
wb/froeht/protolize-dcf
to
feature/protoconv
December 26, 2024 21:41
timothyfroehlich
force-pushed
the
wb/froeht/delete-proto-utils
branch
from
c823e91 to
2467781
Compare
timothyfroehlich
force-pushed
the
wb/froeht/delete-proto-utils
branch
from
2467781 to
a9e6bc5
Compare
rylin8
reviewed
Dec 26, 2024
designcompose/src/main/java/com/android/designcompose/squoosh/SquooshText.kt
Outdated
Show resolved
Hide resolved
timothyfroehlich
force-pushed
the
wb/froeht/delete-proto-utils
branch
from
a9e6bc5 to
9d85eb0
Compare
rylin8
approved these changes
Dec 26, 2024
timothyfroehlich
added a commit
that referenced
this pull request
Dec 26, 2024
<!-- start git-machete generated --> # Based on PR #1947 ## Chain of upstream PRs as of 2024-12-26 * PR #1886: `main` ← `feature/protoconv` * PR #1941: `feature/protoconv` ← `wb/froeht/protolize-dcf` * PR #1943: `wb/froeht/protolize-dcf` ← `wb/froeht/delete-proto-utils` * PR #1946: `wb/froeht/delete-proto-utils` ← `wb/froeht/temp-disable-variant-animation-test` * PR #1947: `wb/froeht/temp-disable-variant-animation-test` ← `wb/froeht/remove-serde-from-kotlin` * **PR #1948 (THIS ONE)**: `wb/froeht/remove-serde-from-kotlin` ← `wb/froeht/resolve-runtime-exceptions` <!-- end git-machete generated --> Protobuf maps are immutable and need to be modified by copying them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #1886
Chain of upstream PRs as of 2024-12-26
PR [PROTOCONV] Convert the Kotlin code to Proto #1886:
main←feature/protoconvfeature/protoconv←wb/froeht/delete-proto-utils