feat(sabsptr): support for DW_EH_PE_sabsptr #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run bloaty against my binary I got "bloaty: Unexpected eh_frame format value: 8" error. According documentation libobjc2 I can interpret this value as signed version of DW_EH_PE_abstr. After further research I found that this library has strange handling for such values [2] and it mentions something about GCC extension. It looks like this value should be returned as is, at least when current logic tries to translate it by calling TranslateVMToFile, this calls fails. When this value is returned as is it looks like I am getting quite valid output for my binary. It might fix google#141 [1] https://github.com/gnustep/libobjc2/blob/master/dwarf_eh.h#L23 [2] https://github.com/gnustep/libobjc2/blob/master/dwarf_eh.h#L200
|
Thanks for the patch! An initial comment: from what I can see, this constant is usually represented as a flag called https://github.com/gnustep/libobjc2/blob/master/dwarf_eh.h#L24 I'll have to dig in a bit more about skipping the translation. |
|
Ping @ak239? |
|
Sorry, I missed a ping. It looks like this |
|
Is anyone working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run bloaty against my binary I got "bloaty: Unexpected
eh_frame format value: 8" error.
According documentation libobjc2 I can interpret this value as
signed version of DW_EH_PE_abstr.
After further research I found that this library has strange handling
for such values [2] and it mentions something about GCC extension.
It looks like this value should be returned as is, at least when
current logic tries to translate it by calling TranslateVMToFile,
this calls fails.
When this value is returned as is it looks like I am getting quite
valid output for my binary.
It might fix #141
[1] https://github.com/gnustep/libobjc2/blob/master/dwarf_eh.h#L23
[2] https://github.com/gnustep/libobjc2/blob/master/dwarf_eh.h#L200