Fix non-standard parsing of DWARF 5 Type Unit Headers (7.5.3) #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to me that the current implementation of DWARF 5 Unit Type Header parsing in CU::ReadHeader does not honour the standard.
Section 7.5.1.3 Type Unit Headers reads:
The current implementation associates
DW_UT_split_type
with Skeleton and Split Compilation Unit Headers (7.5.1.2), wrongly consuming adwo_id
unit ID an missing thetype_signature
andtype_offset
information.