This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Compilation fixes for VS2015 #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pps83
commented
Jul 2, 2018
•
pps83
commented
- corrected printf modifier for size_t (replaced %lu with %zu)
- missing <algorith> include added (needed by std::min/max)
- added static_cast<uint8_t*> for nullptr to be able to resolve ctor for bytes_
- corrected printf modifier for size_t (replaced %lu with %zu) - missing <algorithm> include added (needed by std::min/max) - added static_cast<uint8_t*> for nullptr to be able to resolve ctor for bytes_
pps83
commented
Jul 2, 2018
| @@ -216,7 +216,7 @@ class Image { | |||
| public: | |||
| using T = ComponentType; | |||
|
|
|||
| Image() : xsize_(0), ysize_(0), bytes_per_row_(0), bytes_(nullptr, Ignore) {} | |||
| Image() : xsize_(0), ysize_(0), bytes_per_row_(0), bytes_(static_cast<uint8_t*>(nullptr), Ignore) {} | |||
There was a problem hiding this comment.
no idea why VS doesn't compile it. Without this fix it fails with this error:
1>c:\butteraugli\butteraugli.h(219): error C2661: 'std::unique_ptr<uint8_t [],void (__cdecl *)(void *)>::unique_ptr': no overloaded function takes 2 arguments
1> c:\butteraugli\butteraugli.h(219): note: while compiling class template member function 'butteraugli::Image<float>::Image(void)'
1> c:\butteraugli\butteraugli.cc(1839): note: see reference to function template instantiation 'butteraugli::Image<float>::Image(void)' being compiled
1> c:\butteraugli\butteraugli.cc(106): note: see reference to class template instantiation 'butteraugli::Image<float>' being compiled
Also it seems that vs2017 doesn't have that problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.