Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove if statement whose condition is always false. #31

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Remove if statement whose condition is always false. #31

merged 1 commit into from
Sep 19, 2023

Conversation

jcd2
Copy link
Collaborator

@jcd2 jcd2 commented Sep 19, 2023

The packageNames slice will never be empty. If the flag -packages is empty, packageNames will contain the empty string, and the package in the current directory will be analyzed.

Fixes #28

The packageNames slice will never be empty.  If the flag -packages is empty,
packageNames will contain the empty string, and the package in the current
directory will be analyzed.
@jcd2 jcd2 requested a review from jessmcclintock September 19, 2023 03:12
@jessmcclintock jessmcclintock merged commit ace8b60 into google:main Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ineffective check for len(packageNames) == 0
2 participants