Improve type-checking for DragDrop

RELNOTES: n/a PiperOrigin-RevId: 560726180 Change-Id: Ibcde43f2fed173ce3f4b3b10f4a41d2f0be97f51
google · Aug 28, 2023 · 3148983 · 3148983
1 parent 9cadc89
commit 3148983
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/closure/goog/fx/abstractdragdrop.js b/closure/goog/fx/abstractdragdrop.js
@@ -1323,9 +1323,10 @@ goog.inherits(goog.fx.DragDropEvent, goog.events.Event);
  *
  * @param {Element|string} element Dom Node, or string representation of node
  *     id, to be used as drag source/drop target.
- * @param {Object=} opt_data Data associated with the source/target.
+ * @param {DRAG_DROP_DATA=} opt_data Data associated with the source/target.
  * @throws Error If no element argument is provided or if the type is invalid
  * @extends {goog.events.EventTarget}
+ * @template DRAG_DROP_DATA
  * @constructor
  * @struct
  */
@@ -1341,7 +1342,7 @@ goog.fx.DragDropItem = function(element, opt_data) {
 
   /**
    * Data associated with element.
-   * @type {Object|undefined}
+   * @type {DRAG_DROP_DATA|undefined}
    */
   this.data = opt_data;
 
@@ -1379,7 +1380,7 @@ goog.inherits(goog.fx.DragDropItem, goog.events.EventTarget);
 
 /**
  * Get the data associated with the source/target.
- * @return {Object|null|undefined} Data associated with the source/target.
+ * @return {DRAG_DROP_DATA|undefined} Data associated with the source/target.
  */
 goog.fx.DragDropItem.prototype.getData = function() {
   'use strict';

diff --git a/closure/goog/fx/dragdrop.js b/closure/goog/fx/dragdrop.js
@@ -26,9 +26,10 @@ goog.require('goog.fx.DragDropItem');
  *
  * @param {Element|string} element Dom Node, or string representation of node
  *     id, to be used as drag source/drop target.
- * @param {Object=} opt_data Data associated with the source/target.
+ * @param {DRAG_DROP_DATA=} opt_data Data associated with the source/target.
  * @throws Error If no element argument is provided or if the type is invalid
  * @extends {goog.fx.AbstractDragDrop}
+ * @template DRAG_DROP_DATA
  * @constructor
  * @struct
  */

diff --git a/closure/goog/fx/dragdropgroup.js b/closure/goog/fx/dragdropgroup.js
@@ -42,9 +42,10 @@ goog.inherits(goog.fx.DragDropGroup, goog.fx.AbstractDragDrop);
  *
  * @param {Element|string} element Dom Node, or string representation of node
  *     id, to be used as drag source/drop target.
- * @param {Object=} opt_data Data associated with the source/target.
+ * @param {DRAG_DROP_DATA=} opt_data Data associated with the source/target.
  * @throws Error If no element argument is provided or if the type is
  *     invalid
+ * @template DRAG_DROP_DATA
  * @override
  */
 goog.fx.DragDropGroup.prototype.addItem = function(element, opt_data) {