Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Adding args and kwargs to oauth decorator in appengine #4350

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

vitorguidi
Copy link
Collaborator

@vitorguidi vitorguidi commented Oct 22, 2024

Motivation

#4312 added the oauth handler to several get endpoints, in order for GCP uptime to probe them. However, the decorator assumed that all handlers would be of the form func(self), not declaring args or kwargs.

This is not true, for the following signatures:

coverage_report.py
...
  def get(self, report_type=None, argument=None, date=None, extra=None):
  
fuzzer_stats.py
...
  def get(self, extra=None):

This PR adds *args and **kwargs to the wrapper, so it can work for these endpoints.

Part of #4271

Error groups:
coverage
stats

@vitorguidi vitorguidi changed the title Adding args and kwargs to oauth handler Adding args and kwargs to oauth decorator in appengine Oct 22, 2024
Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vitorguidi vitorguidi merged commit 5a6ce5a into master Oct 23, 2024
7 checks passed
@vitorguidi vitorguidi deleted the fix/oauth-args branch October 23, 2024 15:25
@vitorguidi vitorguidi changed the title Adding args and kwargs to oauth decorator in appengine [Monitoring] Adding args and kwargs to oauth decorator in appengine Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants