[WIP] GHC 8.10.7

[peterbecich]

There is an issue compiling codeworld-base:

$ cabal build codeworld-base
...
dist-newstyle/build/x86_64-linux/ghc-8.10.7/codeworld-base-0.2.0.0/build/Extras/Cw.dyn_o )
ghc: panic! (the 'impossible' happened)
  (GHC version 8.10.7:
        expectJust failed to detect OverLit
CallStack (from HasCallStack):
  error, called at compiler/utils/Maybes.hs:57:27 in ghc:Maybes
  expectJust, called at compiler/GHC/HsToCore/PmCheck.hs:551:16 in ghc:GHC.HsToCore.PmCheck

Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug

This appears to be an instance of https://gitlab.haskell.org/ghc/ghc/-/issues/18708

Cabal 3.6.1.0
GHC 8.10.7
Debian Bullseye

[cdsmith]

Hmm, that's too bad. The good news, though, is that CodeWorld already builds its own patched version of GHCJS, if someone is willing to backport this fix. It doesn't look too difficult to do (it's a small patch!) But I haven't checked whether the surrounding code has changed much since 8.10.7

[cdsmith]

I'd rather keep all the version constraints in one place. Can this be kept in the cabal file?

[cdsmith]

I believe we need upper bounds on versions to upload to hackage. So feel free to relax bounds, but let's leave them in place for codeworld-api. Other packages don't need upper bounds, since they don't get released to hackage.

[cdsmith]

I don't see where this is used.

If it's needed, ghc-lib-parser changes dramatically between versions (it's just a copy of parts of ghc), so it needs version bounds. But it would be better to leave it out and update the ghc code, if it's not too difficult.

[cdsmith]

I almost cringe to ask it, but can you include field names here so the reader has some hope of finding what they need to change in the future?

[cdsmith]

Thanks! I looked up the history, and this was originally added to keep hindent working, but CodeWorld now uses Ormolu instead of hindent, so dropping the restriction is fine.

[peterbecich]

Here is the backport; it solves the error: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/6554

[cdsmith]

Cool! I'm not sure whether there will be a new GHC release in the 8.x series, but if you make a patch (test case not necessary) and drop it in https://github.com/google/codeworld/tree/master/ghc-artifacts, and then apply the patch in install.sh near https://github.com/google/codeworld/blob/master/install.sh#L226, then CodeWorld will build with the change. That should unblock you.

Speaking of patches there, I wonder whether the remaining patches in that directory are still needed. The default main patch was contributed upstream, and has probably made it into GHC 8.10, but I'll verify that. The dedup fix for the linker was a GHCJS patch, and my hope is that it's also merged in the 8.10 branch. Again, I'll try to find evidence for this and report back.

[cdsmith]

I've confirmed that the default main patch does NOT need to be ported. It's already part of GHC 8.10. Unfortunately, ghcjs/ghcjs#788 still isn't merged, so this one needs to be ported forward. There have been changes to that file, so it's not immediately obvious to me how to do so, but @3noch or @tomsmalley may know.